It is usually a good thing. When a company buys its own shares on the open market, it says they have more cash than they need for development of new products and research or whatever, and the company is not spending money frivilously, considering themselves to be a good investment.
Also it reduces the number of shares on the market and increases their earnings per share ratio, both of which drive up the price of the shares. This is good for larger shareholders.