Driveshaft spacers are, as I understand it, a cheap way to make stock driveshafts work.
Ideally, it's best to get a driveshaft that is longer. They put the U-joints as close to the ends of the driveshaft as possible which actually reduces the sharpness of the working angles of the U-joints. Whether that small difference in the working angle of the U-joint is significant can be debated.
Practically speaking, most folks can't afford dropping a bunch of money for custom-length driveshafts. That's why just about every vendor offers driveshaft spacers to solve the problem.
I've have had a set on my truck since 2001 and have had no problems.
I'll be the first to admit that I don't wheel nearly as much as most of you. 90 percent of my driving is on the road and not flexing the suspension off road. The biggest problems I have had with my spacered driveshafts are worn u-joints and loose bolts from removing and reattaching the rear driveshaft when flat-towing - neither of which do I attribute to the spacers I use.
Bottom line: The Ideal World cost money. Spacers don't. They work for me.
Anyone else have thoughts on this?